spree-contrib / spree_print_invoice

Create a PDF invoice for Spree orders.
http://guides.spreecommerce.org
BSD 3-Clause "New" or "Revised" License
91 stars 239 forks source link

Work with Spree 4 & Rails 6 #139

Closed imgarylai closed 4 years ago

imgarylai commented 4 years ago

I'm sorry for sending this huge pull request. :( I originally just wanted to make this excellent gem work first, and didn't think much of what I have done. So, the commits look a little messy.)

However, I believe my works might help somebody. Because there are many good pull requests, and I just organize some of them to make this gem work in a shot time! Since I'm gonna move forward to do other things, I hope someone could help me finish the rest of the things.

What has been done in this pull request?

If this PR looks useful to you, let me know if I can do anything to make this pull request to be merged.

Thank you.

damianlegawiec commented 4 years ago

Hey @imgarylai & @voleoo could you rebase this pull request? Thank you both for you excellent work so far! 💪

imgarylai commented 4 years ago

@damianlegawiec Yeah no problem.

imgarylai commented 4 years ago

@damianlegawiec I think I will create some small PRs to finish reset of the job in this PR because I changed too many things in this PR and some of them might not be necessary.

Let me close this issue first.