search

spree-contrib / spree_print_invoice

Create a PDF invoice for Spree orders.
http://guides.spreecommerce.org
BSD 3-Clause "New" or "Revised" License
91 stars 239 forks source link

Update view & i18n helper. Add new locale zh-TW #143

Closed imgarylai closed 4 years ago

imgarylai commented 4 years ago

This is relevant to #122 & #139

voleoo commented 4 years ago

What about app/views/spree/admin/orders/_print_invoice_order_tab_links.html.erb I think this file also should have small changes 

<% if can? :show, Spree::Order %>
  <% if @order && @order.completed_at? %>
      <li data-hook="admin_order_tabs_documents">
        <%=
          link_to_with_icon 'file',
            Spree.t(:documents, scope: :print_invoice),
            spree.admin_order_bookkeeping_documents_path(@order),
            title: title,
            class: "#{'active ' if current == :documents}nav-link icon-link with-tip action-refresh"
        %>
      </li>
  <% end %>
<% end %>
voleoo commented 4 years ago

And please change name of PR, it's not only about locales

imgarylai commented 4 years ago

Thank you @voleoo

I have updated this PR.

imgarylai commented 4 years ago

@voleoo Thanks for your review. I made the update and pushed it to GitHub.

voleoo commented 4 years ago

It's strange that the github failed, but TravisCI is ok.

@damianlegawiec I think it's should be merged to master for support Spree > 4 Thanks @imgarylai