search

spree-contrib / spree_print_invoice

Create a PDF invoice for Spree orders.
http://guides.spreecommerce.org
BSD 3-Clause "New" or "Revised" License
91 stars 239 forks source link

Logo path doesn't work in 2.1 #35

Open szechyjs opened 11 years ago

szechyjs commented 11 years ago

Logo path is set to prepend /public/assets to the logo path. This does not work with the asset pipeline in 2.1

radar commented 11 years ago

Hi @szechyjs, have you been able to investigate this issue since you posted about it? Would you please be able to do that and submit a patch to fix the problem?

dpritchett commented 10 years ago

/Users/daniel/.rvm/rubies/ruby-2.0.0-p353/lib/ruby/gems/2.0.0/bundler/gems/spree-1fad15562f17/backend/app/assets/images/global/logo.png not found

Using Spree 2-0-master and this gem 2-0-master. I have a file at app/assets/images/global/logo.png that works, but this gem is missing it.

peterberkenbosch commented 10 years ago

Can you show how you set the logo setting @dpritchett ? I cannot reproduce the error with a 2-0-stable clean sandbox and this in config/initializer/spree.rb https://gist.github.com/peterberkenbosch/7807412

dpritchett commented 10 years ago

I'm messing with it locally now, I think I did something dumb with bundler. I'll update again in a while.

FWIW here's my current config:

Spree::PrintInvoice.config do |config|
  config.print_buttons = %w[invoice packaging_slip]
  config.print_invoice_logo_path = "global/logo.png"
end
peterberkenbosch commented 10 years ago

That looks good to me.

radar commented 10 years ago

@dpritchett Do you know if this issue is still ... an issue?