Fixes printing of PDFs with missing logo. Refs #75

spree-contrib / spree_print_invoice

Create a PDF invoice for Spree orders.

http://guides.spreecommerce.org

BSD 3-Clause "New" or "Revised" License

91 stars 239 forks source link

Fixes printing of PDFs with missing logo. Refs #75 #76

Closed tvdeyen closed 9 years ago

tvdeyen commented 9 years ago

Since Rails asset finder returns nil if the logo cannot be found, but File.exist? takes a String we get a TypeError: no implicit conversion of nil into String for missing logos. This fixes this.

tvdeyen commented 9 years ago

The errors in CI are not related to my change. I guess the test setup is broken?

tvdeyen commented 9 years ago

Please merge #79 to fix the test suite. Thanks