search

spree-contrib / spree_print_invoice

Create a PDF invoice for Spree orders.
http://guides.spreecommerce.org
BSD 3-Clause "New" or "Revised" License
91 stars 239 forks source link

Only include spree controller requests test helper in controller specs. #79

Closed tvdeyen closed 9 years ago

tvdeyen commented 9 years ago

The test suite is currently broken

tvdeyen commented 9 years ago

Build #34.1 stalled. Could someone please restart that? Thanks.

JDutil commented 9 years ago

@tvdeyen this extension needs additional maintainers. If you'd be interested in commit access to this or other spree-contrib repos let me know.

tvdeyen commented 9 years ago

@JDutil hmm, I need to discuss this with my team. We have a bunch of work to do with Alchemy already, but yeah I will think about it. Could you just restart the travis build for now? Thanks.

tvdeyen commented 9 years ago

Thanks :+1:

JDutil commented 9 years ago

This was merged w/ 1c14220722bf3cd343a83a7a54b818bd0e944485

JDutil commented 9 years ago

@tvdeyen I should add we don't expect you to handle all the issues/prs, but you understand many of these spree-contrib projects well enough we can use additional maintainers to chip in whatever/whenever you can.

tvdeyen commented 9 years ago

Ok, add me :)

tvdeyen commented 9 years ago

Thanks for merging in.

JDutil commented 9 years ago

@tvdeyen I can either add you to whatever specific repos you want you all spree-contrib. I'll start with just this repo, but if there are others you're also interested in let me know.

tvdeyen commented 9 years ago

spree_i18n ;)

https://github.com/spree-contrib/spree_i18n/issues/530

:D

JDutil commented 9 years ago

You've been added, but we should definitely discuss solution to https://github.com/spree-contrib/spree_i18n/issues/530 in PR or something first before pushing ;)

tvdeyen commented 9 years ago

Yes, for sure!

tvdeyen commented 9 years ago

@JDutil I know there is a spree Trello board. Maybe we should use this board (or a new one under that organistation) to discuss such "issues". Especially the voting feature is nice for such discussions.

My Trello account: tvdeyen (tvd@magiclabs.de)