search

spree-contrib / spree_print_invoice

Create a PDF invoice for Spree orders.
http://guides.spreecommerce.org
BSD 3-Clause "New" or "Revised" License
91 stars 239 forks source link

Pick List per Shipment #83

Open rposborne opened 9 years ago

rposborne commented 9 years ago

Currently it appears this gem targets an entire order. What are thoughts on changing / extending support for a print pick list for each shipment in an order?

futhr commented 9 years ago

@rposborne +1

rposborne commented 9 years ago

@futhr How should we go about this. It feels weird to extend the API shipments controller to render out out a get PDF. Or should we outright add a shipment controller in backends scope?

tvdeyen commented 9 years ago

I would definitely vote for a separate shipments controller. Therefore we can keep the order based documents and can have additional for shipments. We need then to also patch the shipment model, since as with the order, that's where the PDF rendering happens. So extracting the PDF generation out into a module would be best option IMO.

mamhoff commented 9 years ago

https://github.com/spree-contrib/spree_print_invoice/pull/87 will allow you to create PDFs for arbitrary Spree Models, among them Shipments. Because yes, what you want makes complete sense: A packaging slip for a shipment.