spree-contrib / spree_product_zoom

Lightbox zoom functionality to show original product image
http://guides.spreecommerce.org
BSD 3-Clause "New" or "Revised" License
31 stars 95 forks source link

SystemStackError in Spree/products#show => After updating to latest spree Stable 1.2 #13

Closed msevestre closed 11 years ago

msevestre commented 11 years ago

I just updated my gemfile to use the latest version of spree_product_zoom I get the following error spree_product_zoom-665ba34304f8/app/views/spree/products/_thumbnails.html.erb where line # raised:

stack level too deep

Would it be possible to create a stable1-2 branch that we user of spree 1.2 could use?

dunric commented 11 years ago

I can confirm 'stack level too deep' issue with up-to date Spree:

SystemStackError in Spree/products#show

stack level too deep

.../spree_product_zoom-665ba34304f8/app/views/spree/products/_thumbnails.html.erb

Trace of template inclusion: .../spree_core-1.3.1/app/views/spree/products/show.html.erb .../activesupport-3.2.11/lib/active_support/hash_with_indifferent_access.rb:74 parameters: {"id"=>"ruby-on-rails-tote"}

dunric commented 11 years ago

Here is a quick fix to this issue: use the partial products/thumbnails template distributed with the spree_core version you've installed on your system.

In other words, replace spree_product_zoom's "outdated" _thumbnails.html.erb with spree_core-<version>/app/views/spree/products/_thumbnails.html.erb

LBRapid commented 11 years ago

Fixed with https://github.com/spree/spree_product_zoom/commit/93238b6b8312338c707a5d0fc24ca2aa1097bddc