search

spree-contrib / spree_product_zoom

Lightbox zoom functionality to show original product image
http://guides.spreecommerce.org
BSD 3-Clause "New" or "Revised" License
31 stars 95 forks source link

updated to match spree >= 2.1 branch better (rails4 changes), switched to using deface for at least the thumbnails #24

Closed rustycoat closed 10 years ago

rustycoat commented 11 years ago

The build was broken when using with >= spree 2-1-stable and rails4/ruby2 -- was referencing things that weren't defined and expecting nil.

For the _image partial I pulled in the proper conditional from spree_frontend.

For the _thumbnails partial I made a deface override to reduce codebase and allow us to keep in line with spree_frontend easier.

Seems like deface should be used for the _image partial too but it still seems more elegant to rewrite it at this point, since the changes are so significant and the original file so minimal.

JDutil commented 10 years ago

Merged to 2-1-stable branch and master