search

spree-contrib / spree_product_zoom

Lightbox zoom functionality to show original product image
http://guides.spreecommerce.org
BSD 3-Clause "New" or "Revised" License
31 stars 95 forks source link

Spree 2.4 #36

Open kruby opened 9 years ago

kruby commented 9 years ago

Got this to work in spree 2.4 but only after I moved the CSS into a separate file in stylesheets/spree/frontend/xtra_fancybox.css. Also got the arrows (sprites), and other images to work. I took the image files from your github repo and placed them in the public folder, in order to get everything working in production as well. In the CSS files I replaced every instance of background url(<%= 'store/various_photos_here.png' %>) with background url('/various_photos_here.png') product_zoom

JDutil commented 9 years ago

Would you mind submitting a PR with your fixes?

kruby commented 9 years ago

Hi Jeff,

What is a PR?

Venlig hilsen / Kind regards Thomas K. Schmidt

Kruby +45 40 19 68 81 www.kruby.dk

Den 25/11/2014 kl. 17.33 skrev Jeff Dutil notifications@github.com:

Would you mind submitting a PR with your fixes?

— Reply to this email directly or view it on GitHub.

futhr commented 9 years ago

:heart: Pull Request :heart:

kruby commented 9 years ago

Ok. New at this particular thing with GitHub. I am just tying up a few ends. Trying to DRY up things a bit. Will update my first post as well.

kruby commented 9 years ago

I did the Pull Request. Disregard my very first solution. I boiled it down to changing just one file. Hope you agree.

alanalvespi commented 9 years ago

Hi, the modal is not showing up. Also when the mouse its over the image then the label "zoom" at the image bottom it is replaced by another image similar, and the result it is two similar images.

On click the image, the app it is opening the image in the current tab.

My app it is running:

crystalized commented 9 years ago

@alanalvespi I was having the exact same problems as you. I did a fresh install of spree 2.4.5 and then added spree_product_zoom before installing any other extensions. Then I installed the spree_fancy theme and it continued to work.

Update: I tracked down my problem by reinstalling everything piece by piece from scratch. My jssor slider setup js file was interfering with the zoom extension.