search

spree-contrib / spree_related_products

Related products extension for Spree Commerce.
http://guides.spreecommerce.org
BSD 3-Clause "New" or "Revised" License
149 stars 241 forks source link

Not published to rubygems #100

Closed jonmholt closed 9 years ago

jonmholt commented 9 years ago

I would like to include this gem as a dependency in another gem. The easiest way to do that would be for you to publish this to rubygems. Is there a reason not to publish this?

JDutil commented 9 years ago

It's too much of a hassle to maintain stable releases for every extension. You can still include this as a dependency in your gemspec you just also need to specify it in your gemfile as well to run your specs against.

jonmholt commented 9 years ago

I get an error trying to specify a path in the gemspec, suggestions on how best to do that?

On Thu, Dec 18, 2014 at 10:52 AM, Jeff Dutil notifications@github.com wrote:

It's too much of a hassle to maintain stable releases for every extension. You can still include this as a dependency in your gemspec you just also need to specify it in your gemfile as well to run your specs against.

— Reply to this email directly or view it on GitHub https://github.com/spree-contrib/spree_related_products/issues/100#issuecomment-67526062 .

JDutil commented 9 years ago

You don't specify a path in your gemspec you specify the gem name (& version if desired). You specify a path in your Gemfile.

jonmholt commented 9 years ago

Thanks Jeff,

While I'm new to this gem game, the issue I'm having is that while including the related_products in the Gemfile of my gem works when I bundle install the gem, when I include my gem in another project, it can't find the source (ostensibly because the source is specified in the gem Gemfile and not the application Gemfile):

Could not find gem 'spree_related_products (>= 3.2) ruby', which is required by gem 'spree_subscriptions (>= 0) ruby', in any of the sources.

Interestingly, if I don't specify a version for spree_related_products bundler will find version 3.0.2, but for some reason the migrations break when working from that version.

If you have any thoughts, I'd appreciate it.

Jon

On Thu Dec 18 2014 at 10:55:49 AM Jeff Dutil notifications@github.com wrote:

You don't specify a path in your gemspec you specify the gem name (& version if desired). You specify a path in your Gemfile.

— Reply to this email directly or view it on GitHub https://github.com/spree-contrib/spree_related_products/issues/100#issuecomment-67526568 .

futhr commented 9 years ago

Which version of Spree are you using? Neither of these gems seems to be dependent of each other when I look at the 2 latest branches but maybe @alepore can give some input because spree_subscriptions is a gem provided by Nebulab.

jonmholt commented 9 years ago

spree_subscriptions is my own gem, not the one from Nebulab and @alepore (spree-subscriptions). I should probably rename it.

On Fri, Dec 19, 2014 at 11:24 AM, Tobias Bohwalli notifications@github.com wrote:

Which version of Spree are you using? Neither of these gems seems to be dependent of each other when I look at the 2 latest branches but maybe @alepore https://github.com/alepore can give some input because spree_subscriptions is a gem provided by Nebulab https://github.com/nebulab.

— Reply to this email directly or view it on GitHub https://github.com/spree-contrib/spree_related_products/issues/100#issuecomment-67676400 .

JDutil commented 9 years ago

@jonmholt you'll still have to include both gems within your projects Gemfile so that bundler knows where to clone the git repo from since there are not stable gem releases. I would add that to your gems installation readme.