search

spree-contrib / spree_related_products

Related products extension for Spree Commerce.
http://guides.spreecommerce.org
BSD 3-Clause "New" or "Revised" License
149 stars 241 forks source link

Fix invalid pluralization of Spree::RelationType #115

Open jumski opened 9 years ago

jumski commented 9 years ago

I believe this is same stuff as https://github.com/spree-contrib/spree_related_products/pull/107 (related to https://github.com/spree/spree/issues/5842)

Please tell if i should base this on master.

Thanks

futhr commented 9 years ago

Hi @jumski, this fix works for both 3-0-stable and master.

jumski commented 9 years ago

So this should be based on master? Not sure how you propagate this to the stable branch.

futhr commented 9 years ago

Hi @jumski, no worries we can cherry-pick it across branches when the failing specs been resolved.

jumski commented 9 years ago

I don't know how to fix this error, seems unrelated to my changes.

I have checked out 3-0-stable branch and running tests results in same error:

/home/jumski/.rvm/gems/ruby-2.1.5/bundler/gems/spree-438dd5e58c0d/core/lib/spree/testing_support/controller_requests.rb:32:inblock in module:ControllerRequests': undefined method routes' for #<Class:0x00000007181698> (NoMethodError)