search

spree-contrib / spree_related_products

Related products extension for Spree Commerce.
http://guides.spreecommerce.org
BSD 3-Clause "New" or "Revised" License
149 stars 241 forks source link

new branch added - requesting review #18

Closed jsqu99 closed 12 years ago

jsqu99 commented 12 years ago

I pushed an update to the 0.70 branch that removes the 'if false' statements wrapping the 'discount' logic and succesfully hooked in with spree_promo. I also changed the readme to remove the references to the automatic coupons extension.

I have just created a new branch off of master that should mirror these changes verbatim (w/ namespace considersations).

I did not push to master b/c I have not tested it yet.

Does anyone have 10 minutes to verify correctness? I will eventually get to it and wanted to provide this as-is branch for now, just to make it available in the interim.

JDutil commented 12 years ago

I don't have a setup that can test this, but at first glance things look ok to me other than: https://github.com/spree/spree_related_products/commit/3b6c9ea4bde37076455e8d60070f2267bd65eae6#L4R16

BDQ commented 12 years ago

@jsqu99 I finally got to review this just took 2 months, this is great stuff thanks for re-implementing the discounts. I've made a few tweaks and am merging to master.