search

spree-contrib / spree_related_products

Related products extension for Spree Commerce.
http://guides.spreecommerce.org
BSD 3-Clause "New" or "Revised" License
149 stars 241 forks source link

Spree v4.5 support #200

Closed mrbrdo closed 1 month ago

mrbrdo commented 1 year ago

I have merged some old pull requests and added a few of my own commits to make this work on Spree v4.5.

rafalcymerys commented 1 year ago

Hi @mrbrdo great timing, we were just reviewing spree-contrib gems and making adjustments for Rails 7/Spree 4.5 :D Does this PR also include some other PRs that you've created before? Just trying to understand the scope of changes.

mrbrdo commented 1 year ago

@rafalcymerys it doesn't include any prior code of mine, only pull requests from this repo (spree-contrib/spree_related_products) or commits from forks I found in the Github network tab. I only first looked at this gem a few days ago. Btw as mentioned, there is still some code (quite a bit actually) related to this gem inside spree core and spree_legacy_frontend. PS: I am using it with Rails 6. It seems to work fine so far.

SylarRuby commented 1 year ago

Bump. Would love to use this and yes, some references are there for spree_legacy_frontend.

mrbrdo commented 1 month ago

Although not directly related, I just want to note that since Rails 7, it seems double quotes are the norm now. So the houndci-bot rules should probably be updated regarding Style/StringLiterals. Also https://github.com/sendoso/rubocop-sendoso/pull/21

@damianlegawiec since this is related to hound config, probably spree-globally related.

damianlegawiec commented 1 month ago

Thanks @mrbrdo 👍

I'll merge this PR as it is right now, it will require more work to fit into newer Spree versions and new admin/storefront, also setting up proper CI and removing Hound (we don't use that anymore, just standard rubocop)