search

spree-contrib / spree_related_products

Related products extension for Spree Commerce.
http://guides.spreecommerce.org
BSD 3-Clause "New" or "Revised" License
149 stars 241 forks source link

1-0-stable branch? #31

Closed lafeber closed 12 years ago

lafeber commented 12 years ago

I'm running spree on the '1-0-stable' branch. According to the version file here, there should be a branch to make this version work. Unfortunately, there isn't any branch that works with 1-0-stable. So I guess I have to fork.

I feel this is an issue with many spree extensions. Many forks just have one commit and that is setting the dependency to a spree version that works for them.

See for example: https://github.com/yangjindong/spree_related_products/commit/155bfe0a44d21098ebcab27487582df38ca6bea5

I love spree, but errors like:

Bundler could not find compatible versions for gem "spree_promo":
  In Gemfile:
    spree_related_products (>= 0) ruby depends on
      spree_promo (~> 1.1.0) ruby

    spree (>= 0) ruby depends on
      spree_promo (1.0.4.beta)

drive me nuts because they seem so unnecessary.

radar commented 12 years ago

Sorry, this was a mistake on our part. We should've created the 1-0-stable branch. It's now created, go ahead and use that.

lafeber commented 12 years ago

ok thanks!