search

spree-contrib / spree_reviews

Straightforward review/rating functionality.
http://spreecommerce.org
BSD 3-Clause "New" or "Revised" License
126 stars 275 forks source link

Remove Unnecessary spree_frontend gem #198

Open edmondchui opened 1 year ago

edmondchui commented 1 year ago

In the pull request for Spree 4.5 update, spree_frontend gem was introduced as a gem dependency. Since I don't use spree_frontend, I got following error when starting my Spree server:

~/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/spree_auth_devise-4.5.0/lib/controllers/frontend/spree/auth/checkout_controller_decorator.rb:45:in `<top (required)>': uninitialized constant Spree::CheckoutController (NameError)

Spree::CheckoutController.prepend(Spree::Auth::CheckoutControllerDecorator)
     ^^^^^^^^^^^^^^^^^^^^
    from <internal:/Users/echui/.rbenv/versions/3.2.2/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:38:in `require'

Also spree_frontend is mentioned in the Update Gemfile section in Spree 4.5 tp 4.6 migration guide, it should not be added for those not using spree_frontend.

I'm requesting to remove spree_frontend from the gemspec.

iaderblocklack commented 9 months ago

@edmondchui do you found how to solve this issue? I have the same error

edmondchui commented 2 months ago

@iaderblocklack I've already created this pull request https://github.com/spree-contrib/spree_reviews/issues/198#ref-pullrequest-1863869271 a while back. Just need someone to merge.