search

spree / deface

Rails plugin that allows you to customize ERB views in a Rails application without editing the underlying view.
MIT License
520 stars 127 forks source link

Replace colorize gem with rainbow #152

Closed listrophy closed 7 years ago

listrophy commented 8 years ago

The colorize gem is licensed under GPL v2. While I sympathize with the goal of the copyleft licenses, including library code that's licensed under GPL can cause legal headaches. The rainbow gem seems to do the same thing, except with an MIT license.

If replacing a GPL dependency with an MIT one isn't preferred, perhaps:

  1. Remove the 2 calls to .green and 2 calls to .red, or
  2. Use another gem's capability like [bundler][bundler]
  3. Implement the red and green in this codebase

[bundler]: https://github.com/bundler/bundler/blob/20f04aa8923c0d0f02e7a74d5e9609d772351668/lib/bundler/vendor/thor/lib/thor/shell/color.rb

listrophy commented 8 years ago

Changed this to use rainbow instead of console-colors (since it's been deleted from GitHub).

walterg2 commented 8 years ago

Any chance this is going to be implemented? It's pretty much a show stopper for my application to use this gem with the licensing issue contained within.

vfonic commented 7 years ago

👍 Are there any issues with merging this?

damianlegawiec commented 7 years ago

Closed in favour of https://github.com/spree/deface/pull/168