spree / deface

Rails plugin that allows you to customize ERB views in a Rails application without editing the underlying view.
MIT License
519 stars 128 forks source link

`rake deface:test_selector[shared/_head,title]` starts my tests #157

Open stabenfeldt opened 8 years ago

stabenfeldt commented 8 years ago
$ rake deface:test_selector[shared/_head,title]
Running via Spring preloader in process 28589
/Users/martins/.rvm/rubies/ruby-2.2.3/bin/ruby -I/Users/martins/.rvm/gems/ruby-2.2.3@solidus/gems/rspec-core-3.3.2/lib:/Users/martins/.rvm/gems/ruby-2.2.3@solidus/gems/rspec-support-3.3.0/lib /Users/martins/.rvm/gems/ruby-2.2.3@solidus/gems/rspec-core-3.3.2/exe/rspec --pattern spec/\*\*\{,/\*/\*\*\}/\*_spec.rb
gem 'solidus', path:  '/Users/martins/Work/Hoome/solidus', branch: 'master'
Run options: include {:focus=>true}

All examples were filtered out; ignoring {:focus=>true}

Randomized with seed 61475
...................................................

rake deface:test_all on the other hand, works as expected.

Versions solidus (1.3.0.alpha) deface (1.0.2)

stabenfeldt commented 8 years ago
➜  rake deface:failures_by_virtual_path
Running via Spring preloader in process 29122
Error processing overrides for :virtual_path => ''
 undefined method `split' for nil:NilClass

Looks like the rspec task is only started if I provide params to the deface:failures_by_virtual_path task.

➜ rake deface:failures_by_virtual_path['spree/admin/orders/_carton']
Running via Spring preloader in process 29135
/Users/martins/.rvm/rubies/ruby-2.2.3/bin/ruby -I/Users/martins/.rvm/gems/ruby-2.2.3@solidus/gems/rspec-core-3.3.2/lib:/Users/martins/.rvm/gems/ruby-2.2.3@solidus/gems/rspec-support-3.3.0/lib /Users/martins/.rvm/gems/ruby-2.2.3@solidus/gems/rspec-core-3.3.2/exe/rspec --pattern spec/\*\*\{,/\*/\*\*\}/\*_spec.rb

I ran all of the deface tasks with and without arguments.

The rspec task is only triggered when I provide arguments. Without arguments they stop like this:

$ rake deface:test_selector
Failed to find template/partial
0 matches found