Duplicate string before forcing encoding

spree / deface

Rails plugin that allows you to customize ERB views in a Rails application without editing the underlying view.

MIT License

519 stars 128 forks source link

Duplicate string before forcing encoding #182

Closed mikolfaro closed 5 years ago

mikolfaro commented 6 years ago

Solves #181

brchristian commented 5 years ago

@damianlegawiec All strings will be immutable in ruby 3.0, and it is current best practice to use # frozen_string_literal: true in ruby 2.x apps in preparation. Currently this breaks Deface. Can we work towards a merge? Let me know how I can help.