search

spree / deface

Rails plugin that allows you to customize ERB views in a Rails application without editing the underlying view.
MIT License
520 stars 127 forks source link

Fix prefixed attribute parsing #198

Closed meowsus closed 5 years ago

meowsus commented 5 years ago

This may be a less-than-ideal fix for this problem, but at least it's a starting point.

As hinted at in #196 (and originally in #172), due to the custom Haml parser that Deface introduces, recursive, prefixed attributes are not properly handled.

As a stopgap, in this PR I defer to the Haml parser for attributes whose values are found to have nested hashes.

Haml reference: http://haml.info/docs/yardoc/file.REFERENCE.html#prefixed-attributes

meowsus commented 5 years ago

Putting a polite bump on this bad boy