search

spree / deface

Rails plugin that allows you to customize ERB views in a Rails application without editing the underlying view.
MIT License
520 stars 127 forks source link

Issue with slim templates in 1.7.0 #217

Closed storm2513 closed 3 years ago

storm2513 commented 3 years ago

After updating from 1.6.2 to 1.7.0 rails started rendering slim templates as plain files (as it is, without conversion to html)

retsef commented 3 years ago

I have got the same issue, but with haml templates. For now i rolled back to 1.6.x

Environment: ruby 2.7.2 rails 6.1.3 haml-rails 2.0.1 haml 5.2.1

elia commented 3 years ago

Can you please try with revision 85ddb7ac1f3946c6e596c770256ef6bbb70e0060 and see if the problem is already present there?

gem "deface", git: "https://github.com/spree/deface.git", ref: "85ddb7ac1f3946c6e596c770256ef6bbb70e0060"
hoshinotsuyoshi commented 3 years ago

https://github.com/spree/deface/issues/217#issuecomment-784996323

👋 I've got the same issue too. haml.

Environment: ruby 3.0.0 rails 6.1.3 haml-rails 2.0.1 haml 5.2.1

Can you please try with revision 85ddb7ac1f3946c6e596c770256ef6bbb70e0060 and see if the problem is already present there?

gem "deface", git: "https://github.com/spree/deface.git", ref: "85ddb7ac1f3946c6e596c770256ef6bbb70e0060"

I tried that revision. My spree app seems to be working :)

elia commented 3 years ago

I just opened https://github.com/spree/deface/pull/218 which should fix the issue, can any of you confirm it's working and report the version of Rails you tried it on?

elia commented 3 years ago

I just released ~v1.8.0~ v1.8.1, can you confirm it fixes the issue?

zernie commented 3 years ago

@elia nope. still happens sometimes

elia commented 3 years ago

@zernie is it sometimes or all the time with some templates/overrides?

I'm looking for anything that can help reproducing the issue.

zernie commented 3 years ago

@elia practically all the time. I'm using it in a solidus project

elia commented 3 years ago

Thanks, I'll look into it tomorrow (I hope).

On Thu, Apr 29, 2021 at 11:45 AM zernie @.***> wrote:

@elia https://github.com/elia practically all the time. I'm using it in a solidus project

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/spree/deface/issues/217#issuecomment-829092183, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAAIGYCQPLKCTM6DSG6623TLETC5ANCNFSM4YAF3AUA .

elia commented 3 years ago

@zernie I'm unable to reproduce the issue, can you please try and see if you can reproduce it on the deface sandbox app? Maybe it's a specific version combination or something on those lines.

To run the sandbox app:

An alternative would be to push a demo app that shows the problem.

If you find a way to reproduce the problem or push an app please open a separate issue with specific instructions, mentioning me (@elia) and this issue (#217).