Closed alecslupu closed 2 years ago
While working on Decidim upgrade, i have noticed there is an issue caused by deface:
ActionView::Template::Error (can't modify frozen String: "decidim/devise/sessions/new"):
Changing the line:
[/^\//, /\.\w+\z/].each { |regex| virtual_path.gsub!(regex, '') }
to fixes the issue
[/^\//, /\.\w+\z/].each { |regex| virtual_path = virtual_path.gsub(regex, '') }
The full stacktrace:
ActionView::Template::Error (can't modify frozen String: "decidim/devise/sessions/new"): deface (1.8.1) lib/deface/search.rb:13:in `gsub!' deface (1.8.1) lib/deface/search.rb:13:in `block in find' deface (1.8.1) lib/deface/search.rb:13:in `each' deface (1.8.1) lib/deface/search.rb:13:in `find' deface (1.8.1) lib/deface/override.rb:198:in `digest' deface (1.8.1) lib/deface/action_view_extensions.rb:57:in `block in compile!' deface (1.8.1) lib/deface/action_view_extensions.rb:56:in `synchronize' deface (1.8.1) lib/deface/action_view_extensions.rb:56:in `compile!' actionview (7.0.0.rc1) lib/action_view/template.rb:156:in `block in render' activesupport (7.0.0.rc1) lib/active_support/notifications.rb:206:in `block in instrument' activesupport (7.0.0.rc1) lib/active_support/notifications/instrumenter.rb:24:in `instrument' activesupport (7.0.0.rc1) lib/active_support/notifications.rb:206:in `instrument' actionview (7.0.0.rc1) lib/action_view/template.rb:361:in `instrument_render_template' actionview (7.0.0.rc1) lib/action_view/template.rb:155:in `render' actionview (7.0.0.rc1) lib/action_view/renderer/template_renderer.rb:65:in `block (2 levels) in render_template' activesupport (7.0.0.rc1) lib/active_support/notifications.rb:206:in `block in instrument' activesupport (7.0.0.rc1) lib/active_support/notifications/instrumenter.rb:24:in `instrument' activesupport (7.0.0.rc1) lib/active_support/notifications.rb:206:in `instrument' actionview (7.0.0.rc1) lib/action_view/renderer/template_renderer.rb:60:in `block in render_template' actionview (7.0.0.rc1) lib/action_view/renderer/template_renderer.rb:75:in `block in render_with_layout' activesupport (7.0.0.rc1) lib/active_support/notifications.rb:206:in `block in instrument' activesupport (7.0.0.rc1) lib/active_support/notifications/instrumenter.rb:24:in `instrument' activesupport (7.0.0.rc1) lib/active_support/notifications.rb:206:in `instrument' actionview (7.0.0.rc1) lib/action_view/renderer/template_renderer.rb:74:in `render_with_layout' actionview (7.0.0.rc1) lib/action_view/renderer/template_renderer.rb:59:in `render_template' actionview (7.0.0.rc1) lib/action_view/renderer/template_renderer.rb:11:in `render' actionview (7.0.0.rc1) lib/action_view/renderer/renderer.rb:61:in `render_template_to_object' actionview (7.0.0.rc1) lib/action_view/renderer/renderer.rb:29:in `render_to_object' actionview (7.0.0.rc1) lib/action_view/rendering.rb:117:in `block in _render_template' actionview (7.0.0.rc1) lib/action_view/base.rb:270:in `in_rendering_context' actionview (7.0.0.rc1) lib/action_view/rendering.rb:116:in `_render_template' actionpack (7.0.0.rc1) lib/action_controller/metal/streaming.rb:216:in `_render_template' actionview (7.0.0.rc1) lib/action_view/rendering.rb:103:in `render_to_body' actionpack (7.0.0.rc1) lib/action_controller/metal/rendering.rb:46:in `render_to_body' actionpack (7.0.0.rc1) lib/action_controller/metal/renderers.rb:142:in `render_to_body' actionpack (7.0.0.rc1) lib/abstract_controller/rendering.rb:25:in `render' actionpack (7.0.0.rc1) lib/action_controller/metal/rendering.rb:30:in `render' actionpack (7.0.0.rc1) lib/action_controller/metal/instrumentation.rb:22:in `block (2 levels) in render' /usr/local/lib/ruby/2.7.0/benchmark.rb:308:in `realtime' activesupport (7.0.0.rc1) lib/active_support/core_ext/benchmark.rb:14:in `ms' actionpack (7.0.0.rc1) lib/action_controller/metal/instrumentation.rb:22:in `block in render' actionpack (7.0.0.rc1) lib/action_controller/metal/instrumentation.rb:91:in `cleanup_view_runtime' activerecord (7.0.0.rc1) lib/active_record/railties/controller_runtime.rb:34:in `cleanup_view_runtime' actionpack (7.0.0.rc1) lib/action_controller/metal/instrumentation.rb:21:in `render' wicked_pdf (2.1.0) lib/wicked_pdf/pdf_helper.rb:46:in `call' wicked_pdf (2.1.0) lib/wicked_pdf/pdf_helper.rb:46:in `render_with_wicked_pdf' wicked_pdf (2.1.0) lib/wicked_pdf/pdf_helper.rb:30:in `render' responders (3.0.1) lib/action_controller/responder.rb:240:in `default_render' responders (3.0.1) lib/action_controller/responder.rb:172:in `to_html' responders (3.0.1) lib/action_controller/responder.rb:165:in `respond' responders (3.0.1) lib/action_controller/responder.rb:158:in `call' responders (3.0.1) lib/action_controller/respond_with.rb:213:in `respond_with' devise (9f5b83750eef) app/controllers/devise/sessions_controller.rb:14:in `new' actionpack (7.0.0.rc1) lib/action_controller/metal/basic_implicit_render.rb:6:in `send_action' actionpack (7.0.0.rc1) lib/abstract_controller/base.rb:214:in `process_action' actionpack (7.0.0.rc1) lib/action_controller/metal/rendering.rb:53:in `process_action' actionpack (7.0.0.rc1) lib/abstract_controller/callbacks.rb:234:in `block in process_action' activesupport (7.0.0.rc1) lib/active_support/callbacks.rb:118:in `block in run_callbacks' i18n (1.8.11) lib/i18n.rb:314:in `with_locale' decidim/decidim-core/app/controllers/concerns/decidim/locale_switcher.rb:24:in `switch_locale' activesupport (7.0.0.rc1) lib/active_support/callbacks.rb:127:in `block in run_callbacks' actiontext (7.0.0.rc1) lib/action_text/rendering.rb:20:in `with_renderer' actiontext (7.0.0.rc1) lib/action_text/engine.rb:69:in `block (4 levels) in <class:Engine>' activesupport (7.0.0.rc1) lib/active_support/callbacks.rb:127:in `instance_exec' activesupport (7.0.0.rc1) lib/active_support/callbacks.rb:127:in `block in run_callbacks' activesupport (7.0.0.rc1) lib/active_support/callbacks.rb:138:in `run_callbacks' actionpack (7.0.0.rc1) lib/abstract_controller/callbacks.rb:233:in `process_action' actionpack (7.0.0.rc1) lib/action_controller/metal/rescue.rb:22:in `process_action' actionpack (7.0.0.rc1) lib/action_controller/metal/instrumentation.rb:67:in `block in process_action' activesupport (7.0.0.rc1) lib/active_support/notifications.rb:206:in `block in instrument' activesupport (7.0.0.rc1) lib/active_support/notifications/instrumenter.rb:24:in `instrument' activesupport (7.0.0.rc1) lib/active_support/notifications.rb:206:in `instrument' actionpack (7.0.0.rc1) lib/action_controller/metal/instrumentation.rb:66:in `process_action' actionpack (7.0.0.rc1) lib/action_controller/metal/params_wrapper.rb:259:in `process_action' activerecord (7.0.0.rc1) lib/active_record/railties/controller_runtime.rb:27:in `process_action' actionpack (7.0.0.rc1) lib/abstract_controller/base.rb:151:in `process' actionview (7.0.0.rc1) lib/action_view/rendering.rb:39:in `process' actionpack (7.0.0.rc1) lib/action_controller/metal.rb:188:in `dispatch' actionpack (7.0.0.rc1) lib/action_controller/metal.rb:251:in `dispatch' actionpack (7.0.0.rc1) lib/action_dispatch/routing/route_set.rb:49:in `dispatch' actionpack (7.0.0.rc1) lib/action_dispatch/routing/route_set.rb:32:in `serve' actionpack (7.0.0.rc1) lib/action_dispatch/routing/mapper.rb:18:in `block in <class:Constraints>' actionpack (7.0.0.rc1) lib/action_dispatch/routing/mapper.rb:48:in `serve' actionpack (7.0.0.rc1) lib/action_dispatch/journey/router.rb:50:in `block in serve' actionpack (7.0.0.rc1) lib/action_dispatch/journey/router.rb:32:in `each' actionpack (7.0.0.rc1) lib/action_dispatch/journey/router.rb:32:in `serve' actionpack (7.0.0.rc1) lib/action_dispatch/routing/route_set.rb:850:in `call' railties (7.0.0.rc1) lib/rails/engine.rb:530:in `call' railties (7.0.0.rc1) lib/rails/railtie.rb:224:in `public_send' railties (7.0.0.rc1) lib/rails/railtie.rb:224:in `method_missing' actionpack (7.0.0.rc1) lib/action_dispatch/routing/mapper.rb:19:in `block in <class:Constraints>' actionpack (7.0.0.rc1) lib/action_dispatch/routing/mapper.rb:48:in `serve' actionpack (7.0.0.rc1) lib/action_dispatch/journey/router.rb:50:in `block in serve' actionpack (7.0.0.rc1) lib/action_dispatch/journey/router.rb:32:in `each' actionpack (7.0.0.rc1) lib/action_dispatch/journey/router.rb:32:in `serve' actionpack (7.0.0.rc1) lib/action_dispatch/routing/route_set.rb:850:in `call' batch-loader (1.5.0) lib/batch_loader/middleware.rb:11:in `call' omniauth (2.0.4) lib/omniauth/strategy.rb:202:in `call!' omniauth (2.0.4) lib/omniauth/strategy.rb:169:in `call' omniauth (2.0.4) lib/omniauth/builder.rb:45:in `call' warden (1.2.9) lib/warden/manager.rb:36:in `block in call' warden (1.2.9) lib/warden/manager.rb:34:in `catch' warden (1.2.9) lib/warden/manager.rb:34:in `call' decidim/decidim-core/lib/decidim/middleware/strip_x_forwarded_host.rb:12:in `call' decidim/decidim-core/lib/decidim/middleware/current_organization.rb:22:in `call' rack (2.2.3) lib/rack/tempfile_reaper.rb:15:in `call' rack (2.2.3) lib/rack/etag.rb:27:in `call' rack (2.2.3) lib/rack/conditional_get.rb:27:in `call' rack (2.2.3) lib/rack/head.rb:12:in `call' actionpack (7.0.0.rc1) lib/action_dispatch/http/permissions_policy.rb:22:in `call' actionpack (7.0.0.rc1) lib/action_dispatch/http/content_security_policy.rb:18:in `call' rack (2.2.3) lib/rack/session/abstract/id.rb:266:in `context' rack (2.2.3) lib/rack/session/abstract/id.rb:260:in `call' actionpack (7.0.0.rc1) lib/action_dispatch/middleware/cookies.rb:693:in `call' activerecord (7.0.0.rc1) lib/active_record/migration.rb:603:in `call' actionpack (7.0.0.rc1) lib/action_dispatch/middleware/callbacks.rb:27:in `block in call' activesupport (7.0.0.rc1) lib/active_support/callbacks.rb:99:in `run_callbacks' actionpack (7.0.0.rc1) lib/action_dispatch/middleware/callbacks.rb:26:in `call' actionpack (7.0.0.rc1) lib/action_dispatch/middleware/executor.rb:14:in `call' actionpack (7.0.0.rc1) lib/action_dispatch/middleware/actionable_exceptions.rb:17:in `call' actionpack (7.0.0.rc1) lib/action_dispatch/middleware/debug_exceptions.rb:28:in `call' web-console (4.0.4) lib/web_console/middleware.rb:132:in `call_app' web-console (4.0.4) lib/web_console/middleware.rb:19:in `block in call' web-console (4.0.4) lib/web_console/middleware.rb:17:in `catch' web-console (4.0.4) lib/web_console/middleware.rb:17:in `call' actionpack (7.0.0.rc1) lib/action_dispatch/middleware/show_exceptions.rb:26:in `call' railties (7.0.0.rc1) lib/rails/rack/logger.rb:36:in `call_app' railties (7.0.0.rc1) lib/rails/rack/logger.rb:25:in `block in call' activesupport (7.0.0.rc1) lib/active_support/tagged_logging.rb:99:in `block in tagged' activesupport (7.0.0.rc1) lib/active_support/tagged_logging.rb:37:in `tagged' activesupport (7.0.0.rc1) lib/active_support/tagged_logging.rb:99:in `tagged' railties (7.0.0.rc1) lib/rails/rack/logger.rb:25:in `call' actionpack (7.0.0.rc1) lib/action_dispatch/middleware/remote_ip.rb:93:in `call' request_store (1.5.0) lib/request_store/middleware.rb:19:in `call' actionpack (7.0.0.rc1) lib/action_dispatch/middleware/request_id.rb:26:in `call' rack (2.2.3) lib/rack/method_override.rb:24:in `call' actionpack (7.0.0.rc1) lib/action_dispatch/middleware/server_timing.rb:20:in `call' actionpack (7.0.0.rc1) lib/action_dispatch/middleware/executor.rb:14:in `call' actionpack (7.0.0.rc1) lib/action_dispatch/middleware/static.rb:23:in `call' rack (2.2.3) lib/rack/sendfile.rb:110:in `call' actionpack (7.0.0.rc1) lib/action_dispatch/middleware/host_authorization.rb:116:in `call' webpacker (6.0.0.rc.5) lib/webpacker/dev_server_proxy.rb:25:in `perform_request' rack-proxy (0.7.0) lib/rack/proxy.rb:63:in `call' rack-cors (1.1.1) lib/rack/cors.rb:100:in `call' railties (7.0.0.rc1) lib/rails/engine.rb:530:in `call' puma (5.5.2) lib/puma/configuration.rb:249:in `call' puma (5.5.2) lib/puma/request.rb:77:in `block in handle_request' puma (5.5.2) lib/puma/thread_pool.rb:340:in `with_force_shutdown' puma (5.5.2) lib/puma/request.rb:76:in `handle_request' puma (5.5.2) lib/puma/server.rb:447:in `process_client' puma (5.5.2) lib/puma/thread_pool.rb:147:in `block in spawn_thread'
While working on Decidim upgrade, i have noticed there is an issue caused by deface:
Changing the line:
to fixes the issue
The full stacktrace: