search

spree / endpoint_base

MIT License
7 stars 16 forks source link

Create a `add_messages` to ResponseDSL #4

Closed huoxito closed 10 years ago

huoxito commented 10 years ago

@phstc here's the add_messages we talked about. Maybe it's time

huoxito commented 10 years ago

github submitted PR before I wanted to. You think it's time to write some specs for ResponseDSL? I guess my lazyness right now and the fact that the code is really simple prevents me from trying further to write the specs.

phstc commented 10 years ago

@huoxito Awesome change! I tried to add a unit test, but it started getting complex, so I added a Sinatra test for now. Could you check it, please?

https://github.com/spree/endpoint_base/commit/bae0ad47b4b1 https://github.com/spree/endpoint_base/commit/3925ddc58d77b610b5958bf0bc0f589308664832

huoxito commented 10 years ago

looks good to me @phstc thanks!