search

spree / endpoint_base

MIT License
7 stars 16 forks source link

Rack dependency? #6

Open radar opened 10 years ago

radar commented 10 years ago

Shouldn't this gem enforce a Rack dependency? We have an issue filed over here where the user's application is missing the Rack gem. It seems like since the endpoint base works with either Sinatra or Rails then we should at least have a Rack dependency, no?

phstc commented 10 years ago

It could help with troubleshooting, because users will jump to this error:

[Endpoint Base] Neither Rails or Sinatra are defined, you must manually require the relevant endpoint_base files.

Which is more descriptive.

But in fact endpoint_base must be used with Sinatra or Rails and both include rack.

Can rack without version as a runtime dependency cause other problems? 

gem.add_dependency 'rack'