search

spree / spree_auth_devise

Provides authentication (user accounts, login & signup) for @spree by using Devise
https://spreecommerce.org
BSD 3-Clause "New" or "Revised" License
139 stars 493 forks source link

Add scope to routes, to unify url with frontend #570

Closed wjwitek closed 1 year ago

wjwitek commented 2 years ago

Change locale from being in url as param, to being part of url, using scope in routes. It will break locale for legacy_frontend however (they'll be lost while clicking log out etc.), without this fix https://github.com/spree/spree_legacy_frontend/pull/31.

nciemniak commented 1 year ago

@wjwitek , I think I found a place where the locale is still not persisting, can you check it out?

Steps:

  1. Set locale to fr
  2. Login
  3. Click "Ajouter une nouvelle adresse" (add new address), or update an existing address
  4. Enter a new address and click save button At this point, when it redirects back to the account page, the locale does not propagate and defaults back to english.

Hopefully I've correctly replicated your setup :P

nciemniak commented 1 year ago

Great so far on covering the various test cases, this'll really help us make sure we're not breaking locale in the future. I feel like this'll be good to go once the tests are ironed out 💪