search

spree / spree_auth_devise

Provides authentication (user accounts, login & signup) for @spree by using Devise
https://spreecommerce.org
BSD 3-Clause "New" or "Revised" License
139 stars 493 forks source link

4.5.0 breaks rails version resolution (bundler) #572

Closed mrbrdo closed 1 year ago

mrbrdo commented 1 year ago

Between 0de310f918728960a89880679694a4a1162115ec and current commit b373a785c007316e77bc8a6c30ee10969dbde794, something broke the dependency resolution in certain conditions. Not sure what exactly, but running bundle update produces the error below. From the error it is not obvious to me which version constraint is being violated, but something seems to be bothering bundler. After locking spree_auth_devise to ref 0de310f918728960a89880679694a4a1162115ec, all is well. PS: I am using spree_legacy_frontend.

Bundler could not find compatible versions for gem "activerecord":
  In Gemfile:
    database_cleaner-active_record was resolved to 2.0.1, which depends on
      activerecord (>= 5.a)

    rails (~> 6.1.4, >= 6.1.4.6) was resolved to 6.1.7, which depends on
      activerecord (= 6.1.7)

    my_custom_spree_extension was resolved to 1.0.0, which depends on
      spree_auth_devise (>= 3.1.0, < 5.0) was resolved to 4.5.0, which depends on
        spree_core (>= 4.5.0) was resolved to 4.5.0, which depends on
          activerecord (>= 6.1)
mrbrdo commented 1 year ago

Oh nevermind, I guess it's because you released Spree 4.5.0 and I have my own branch of spree which is still on alpha. That error is cryptic though.