Closed iloveitaly closed 10 years ago
I agree that this should fall back. Can you please submit a patch for this?
@iloveitaly working on it. Agree that raising an exception is a bit to tight.
@iloveitaly I changed the logic on 1-3-stable. Working on getting the specs green again. There are some issues with rspec and posting json there. current WIP is here: https://github.com/spree/spree_wombat/tree/fallback-to-state_name
Closed with 612a3a484c054cc78deb9047e50e647b0ad7ec59
@iloveitaly should be good to go now!
Tested this today, worked great! Thanks @peterberkenbosch!
The shipment handlers do not fallback to setting the
state_name
of an address object if a state object cannot be found, instead an exception is thrown. We ship orders internationally, but do not have the states of all of the countries which ship to in the spree database, so for us this throws an exception and the order is not shipped.Would there be any reason if a state object cannot be found we shouldn't just use the state_name field?