spreedly / gala

Ruby library for decrypting Apple Pay payment tokens
MIT License
41 stars 24 forks source link

Openssl 3 and other dev dependency bumps #19

Open machty opened 2 years ago

machty commented 2 years ago

Closes #17 Closes #16 (includes its rake version dep bump)

Not sure why the CircleCI isn't firing, but when I run rake test locally I get a failure, but i think it's due to the certificate having expired in 2016

rake test
Run options: --seed 31379

# Running:

..E

Error:
Gala::PaymentTokenTest#test_decrypt:
Gala::PaymentToken::InvalidSignatureError: Unable to verify a valid chain of trust from signature to root certificate.
    /Users/machty/code/fpr/external/gala/lib/gala/payment_token.rb:61:in `validate_signature'
    /Users/machty/code/fpr/external/gala/lib/gala/payment_token.rb:30:in `decrypt'
    /Users/machty/code/fpr/external/gala/test/payment_token_test.rb:43:in `test_decrypt'

rails test Users/machty/code/fpr/external/gala/test/payment_token_test.rb:42

F

Failure:
Gala::PaymentTokenTest#test_failed_decrypt [/Users/machty/code/fpr/external/gala/test/payment_token_test.rb:60]:
--- expected
+++ actual
@@ -1 +1 @@
-"The given signature is not a valid ECDSA signature."
+"Unable to verify a valid chain of trust from signature to root certificate."

rails test Users/machty/code/fpr/external/gala/test/payment_token_test.rb:55

..

Finished in 0.014921s, 402.1178 runs/s, 737.2160 assertions/s.
6 runs, 11 assertions, 1 failures, 1 errors, 0 skips
rake aborted!
Command failed with status (1)
TomA-R commented 1 year ago

Hi @InPermutation or @rwdaigle, this would be really great to get reviewed (and merged+released), let us know if there's anything missing! Thanks in advance!

bradbroge commented 1 year ago

@TomA-R #22 will update SSL to 3.1, which is moving through our PR process now, which should close this as well.

TomA-R commented 1 year ago

@TomA-R #22 will update SSL to 3.1, which is moving through our PR process now, which should close this as well.

Fantastic, thank you!