search

spreedly / gala

Ruby library for decrypting Apple Pay payment tokens
MIT License
41 stars 24 forks source link

Use Shopify aead instead of OneLogin #8

Closed davidsantoso closed 7 years ago

davidsantoso commented 7 years ago

There a compatibiliy issue with Ruby 2.2+ which causes the following error when trying to decrypt the payment_data blog:

TypeError (wrong argument type OpenSSL::Cipher (expected Data))

Unfortunately the the fix is not being merged in to the OneLogin aead repo. However, Shopify has fixed this in their fork from OneLogin so this updates to point to Shopify's aead so Gala works in Ruby >= 2.2.0

See https://github.com/onelogin/aead/issues/8 for more details on the issue.

davidsantoso commented 7 years ago

@rwdaigle I should probably note that I didn't do a version bump cause I wasn't sure if it was necessary? Sort of a bug fix so I guess we could do a patch version of 0.3.1. Let me know if I should add.

davidsantoso commented 7 years ago

@rwdaigle updated. Also, wondering if I should add a version bump to v0.3.1?

rwdaigle commented 7 years ago

Ah, yes, 0.3.1 👍