search

spremi / cnijfilter-source-3.80

Canon Printer Drivers for Linux v3.80 updated to build with newer Fedora systems.
2 stars 2 forks source link

Compile fixes #2

Open tokiclover opened 7 years ago

tokiclover commented 7 years ago

Hi, it seems a few things remain unfixed--mainly including standard headers in order to compile the whole package. Additionnaly, there is an ABI x86_32 fix in case of cross compiling or when using x86 ABI on amd64 architecture. The others tiny fixes relate to installation linked to distribution.

If you don't need any of the patch, I can pretty much remove any or all of theme. Thanks for sharing this.

spremi commented 7 years ago

Thanks for updates. Just noticed them...

I will soon go through and apply patches / share any query/ feedback.

spremi commented 7 years ago

Finally got some free time and remembered to review the pull request. Here is the summary:

bd6b6df: cngpijmon/src/bjcupsmon_cups.c: include <cups/ppd.h> Not applying. The file cups/ppd.h is already included 2 lines above.

c1f5c82: cnijfilter/src/bjfimage.c: libpng15 fix Applied.

a663b5c: pstocanonij/filter/Makefile.am: install filters to LIBEXEC Applies. But leads to this error:

install: cannot stat '/home/develop/rpmbuild/BUILDROOT/cnijfilter-ip7200series-3.85-1.x86_64/usr/lib/cups/filter/pstocanonij': No such file or directory
error: Bad exit status from /var/tmp/rpm-tmp.Luxylu (%install)

Haven't looked at resolution as you may already have the fix handy.

ec96584: backendnet/backend/Makefile.am: install backends to LIBEXEC Applies. But, couldn't verify due to error above.

1b2e017: **/configure.ac: support x86_32 ABI Applies. But, couldn't verify due to error above.

e0b3719: cngpijmon/cnijnpr/cnijnpr/cnijnpr.c: inclde standard headers unistd.h is already being included. Do we still need to inclde 'sys/types.h'?

Pushed commits to branch fix.tokiclover. Can you test against this branch?