sprin / pg-discuss

A comment system backend in Python with PostgreSQL
http://pg-discuss.sprin.io/
10 stars 1 forks source link

Remove decorator capability from "exempt" methods in view middleware #2

Closed sprin closed 9 years ago

sprin commented 9 years ago

We have three view middleware classes that define a method "exempt" that can be used as a decorator. However, the decorator capability should be removed since it can lead to circular imports and the side-effects of the decorator can be hard to reason about. There are actually no uses of "exempt" as a decorator in the code because of this: plain method calls are used instead.

The decorator capability should be removed and the docstrings updated in these classes: IdentityPolicyManager CsrfHeaderExt CsrfTokenExt