search

spring-attic / atom-concourse

Other
8 stars 11 forks source link

Error with language pack #4

Closed Asgoret closed 6 years ago

Asgoret commented 6 years ago

Hi!

I install atom plugin via atom settings and catch strange error in Outline view. image How can i fix it? Reinstall isn`t help me.

BoykoAlex commented 6 years ago

Hmm... that works for me with the latest 0.4.0... Is that the version you have installed? Which version of Atom do you have? Do you get hovers and content assist in the editor? Is the only thing not working being the outline content? Did you try hiding it and then opening the outline view again? Also try opening dev tools (View -> Developer -> Toggle Developer Tools). See what's the console. The console should show comm messages between atom and LS process. One of the messages around the bottom should be: Concourse-Pipeline-YAML (Concourse-Pipeline-YAML) rpc.sendRequest textDocument/documentSymbol Check what are the contents of the message. It should have the content for the outline view

Asgoret commented 6 years ago

@BoykoAlex Hi! My Atom version is 1.27.1. From setting i have 0.4.0 version of plugin. No, i haven't got any problems in editor. How can i check Outline? I don't use it before). And yes i tried to hide\reload view and atom.

hhhmmm....it's very strange, but i haven't got any messages from concourse in developer toogle. can it be wrong installation or i missed some packages?

Asgoret commented 6 years ago

@BoykoAlex Ok....It work now, but very odd. For example, i must add folder with pipeline like a project, without that Outline doesn't work. But, Outline not for all files from tutorial image

Green files work fine and orange or not colored files doesn't work(((

UPD: And you must delete last empty row or outline doesn't work for green file.

Asgoret commented 6 years ago

Orange file image

Green file image

Asgoret commented 6 years ago

Work image

Don't work image

BoykoAlex commented 6 years ago

Atom's outline works with only one outline provider. Probably the latest provider's content is being displayed. Do you have 'ide-yamlpackage installed? If you switch between grammars, i.e.YAMLandConcourse-Task-YAML` the outline view won't automatically refresh itself. You'd have to type something to refresh the outline.

Now, Concourse-Task-YAML doesn't have an outline, not supported the LS. Concourse-Pipeline-YAML outline is supported by the LS.

The outline that you see for the pipeline file is not coming from the Concourse LS. I'll paste you how it looks below:

screen shot 2018-07-22 at 17 35 50

The Outline view sometimes seem to be stuck. If you see that "blue spinning circle" for a while close the view and reooen it.

BoykoAlex commented 6 years ago

Looks like if the Outline view is opened and a new pipeline or task file is opened then you get a spinning circle in the outline. This is a bug in the atom language client. This should trigger textDocument/documentSymbol request ones LS initializes and Outline view is opened. Raised: https://github.com/atom/atom-languageclient/issues/229

Asgoret commented 6 years ago

Since it's error somewhere in atom. Close issue.