search

spring-attic / aws-maven

Apache License 2.0
214 stars 175 forks source link

Deployment of duplicate release version should fail #55

Open tonicsoft opened 7 years ago

tonicsoft commented 7 years ago

When deploying a release version, the plugin should fail if the same release version already exists in that location. This is because, to my knowledge, there is no way to remove "editing" permissions with Amazon S3, therefore protection against modifying already released versions must come from the plugin.

Current behaviour is that the deployment succeeds and overwrites the existing version in S3.

tonicsoft commented 7 years ago

I may be willing to work on this if people agree it's a good idea. However, I'm sure it's a very quick change for someone familiar with the project.

gmussi commented 5 years ago

I vote this down. The current behavior (override) is desirable. I believe a flag for this would be better than changing the current behavior.

mjallday commented 5 years ago

I wouldn’t expect a version to change after release even to fix a bug. It should be static.

Cut a new release if there’s a change required for that version.

gmussi commented 5 years ago

In general, yes, but you should change on your pom from 3.4 to 3.4.1 (for example). If 3.4 stands on your pom, and there is already a 3.4 on the repository, it should be overridden.