search

spring-attic / aws-maven

Apache License 2.0
214 stars 174 forks source link

Making Artifacts Public configuration #70

Open aritgithub opened 5 years ago

aritgithub commented 5 years ago

I have a IAM user with S3 write access privileges and a generic maven repository bucket (Buckets and objects not public) without any AWS Bucket Policy specified. Why do I have to set the flag [Public Access Settings -> Manage public access control list (ACLs) -> Block new public ACLs and uploading public objects] to False for the deploy to work? The similar operation with "aws s3 cp ... " command, and same credentials used for mvn deploy, works well with all [Public Access Settings] flags set to True.

jeugene commented 5 years ago

This is a bug in this code. The code enforces "public" putObject ACL. You can git clone this code and see the issue.

I fixed it and send them PR. But the comitters would not merge and looks like this a dead project. I am working on releasing a fork.

Joe

On Tue, Feb 12, 2019, 6:14 AM aritgithub <notifications@github.com wrote:

I have a IAM user with S3 write access privileges and a generic maven repository bucket (Buckets and objects not public) without any AWS Bucket Policy specified. Why do I have to set the flag [Public Access Settings -> Manage public access control list (ACLs) -> Block new public ACLs and uploading public objects] to False for the deploy to work? The similar operation with "aws s3 cp ... " command, and same credentials used for mvn deploy, works well with all [Public Access Settings] flags set to True.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/spring-projects/aws-maven/issues/70, or mute the thread https://github.com/notifications/unsubscribe-auth/APKJqOEcY1EVQxruhKtiD0D_ZkpI8bkJks5vMqImgaJpZM4a2KWU .

aritgithub commented 5 years ago

Thanks Joe, indeed I detected this error in this GitHub sponsored project:

github.com/platform-team/aws-maven

which support all AWS region and the latest cryptographic communication algorithms (AWS4?). Can you send a PR with your fixes to this forked project?

aritgithub commented 5 years ago

Can you send me a ref to the pull request submitted?

jeugene commented 5 years ago

This project is abandoned. Nobody replies.

I put the fix PR here. This project appears to be more active.

https://github.com/platform-team/aws-maven/pull/14

FYI: You may want to use an IAM role instead of an IAM user. I have tested all this with AWS Codebuild and CodePipeline.

Joe

On Tue, Feb 12, 2019, 10:44 AM aritgithub <notifications@github.com wrote:

Thanks Joe, indeed I detected this error in this GitHub sponsored project:

github.com/platform-team/aws-maven

which support all AWS region and the latest cryptographic communication algorithms (AWS4?). Can you send a PR with your fixes to this forked project?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/spring-projects/aws-maven/issues/70#issuecomment-462810688, or mute the thread https://github.com/notifications/unsubscribe-auth/APKJqPU0-nQ-otZaAYEYGUSToe0xwwXaks5vMuFMgaJpZM4a2KWU .