spring-attic / eclipse-integration-gradle

Gradle Tooling for Eclipse
Eclipse Public License 1.0
298 stars 108 forks source link

Re-ordered remapped project references to be put at the end of the classpath #74

Closed shanman190 closed 9 years ago

shanman190 commented 9 years ago

Due to the order of dependencies on the build path with projects coming before artifact dependencies, this causes issues during runtime if you have dependencies on third party artifacts.

Eg

Project A:

...
dependencies {
    compile "org.springframework:spring-web:3.2.0.RELEASE"
}
...

Project B:

...
dependencies {
    compile "group:project-a:+"
    compile "org.springframework:spring-web:4.1.0.RELEASE"
}
...

Given the above two projects, where 'project-a' maps to the local project 'Project A' the order or dependencies on the build path is incorrect. With the plugin's current order, it results in the 3.2.0 dependency being presented first in the runtime classpath when running 'Project B' instead of the properly resolved 4.1.0 dependency that is shown in the classpath container and what would be resolved by invoking gradle from the command line.

shanman190 commented 9 years ago

Created issue STS-3997

kdvolder commented 9 years ago

Pull request looks like a nice small fix. But before I can merge it you need to sing the CLA, did you do this already? (Information about this is at the bottom of the project's readme file).

shanman190 commented 9 years ago

Yep, I've already signed it.

kdvolder commented 9 years ago

Thanks :-) Merged.