artembilan
commented
7 years ago Thank you for the pointer @bericoberin !
The default service name, instance id and port, taken from the
Environment, are${spring.application.name}, the Spring Context ID and${server.port}respectively.
Meanwhile the binder-specific target Boot application has this application.properties:
spring.application.name=${vcap.application.name:http-source}
info.app.name=@project.artifactId@
info.app.description=@project.description@
info.app.version=@project.version@Therefore we are good to go just with the @EnableDiscoveryClient.
Although we might need to think how to add all possible Discovery Clients implementations and activate only that one which has been selected by end-user:
http://cloud.spring.io/spring-cloud-static/Dalston.SR1/#__enablediscoveryclient
How to activate
Including a dependency on
org.springframework.cloud:spring-cloud-starter-zookeeper-discoverywill enable auto-configuration that will setup Spring Cloud Zookeeper Discovery.
At the same time we might need to think about making this feature for all the out-of-the-box applications, since they are Spring Boot apps as well and there is definitely fully supported Boot management and health check.
WDYT, @viniciusccarvalho , @sobychacko ?
viniciusccarvalho
novettaberin
The usefulness of the HttpSource starter app is severely limited by the fact it does not support finding it through the discovery service.
Proposal:
This allows one service to kick off processing with minimal setup by setting up it's rest client to find the HttpSource by a simple URL like "http://http-source/" and we don't have to worry about assuming what port it is listening on or what docker image it is being hosted in.