search

spring-attic / http

Apache License 2.0
7 stars 12 forks source link

Upgrade to Cloud/Boot 2.0, add CORS support #12

Closed artembilan closed 6 years ago

artembilan commented 6 years ago

Related to https://github.com/spring-cloud-stream-app-starters/app-starters-release/issues/134

See https://stackoverflow.com/questions/48675312/how-do-i-patch-the-spring-cloud-stream-http-source-app-starter-to-support-cors

Fixes spring-cloud-stream-app-starters/http#13

tzolov commented 6 years ago

@artembilan it seems like there is a compilation issue: 

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project spring-cloud-starter-stream-source-http: Compilation failure
[ERROR] /Users/ctzolov/Dev/projects/scdf/tmp/merge-gh-12-http-source/http/spring-cloud-starter-stream-source-http/src/main/java/org/springframework/cloud/stream/app/http/source/HttpSourceConfiguration.java:[91,26] cannot access javax.servlet.Filter
[ERROR] class file for javax.servlet.Filter not found

Do the tests pass for you?

tzolov commented 6 years ago

Rebased, squashed and merged at 3d089dc