Use core/app-starters-security-common for security management - Githubissues

spring-attic / http

Apache License 2.0

7 stars 12 forks source link

Use core/app-starters-security-common for security management #25

Closed tzolov closed 5 years ago

tzolov commented 6 years ago

Add core/app-starters-security-common dependency.
Remove the internal security management in favor of using the core/app-starters-security-common module.
Replace local enableSecurity and enableCsrf properties by and spring.cloud.stream.security.enabled and spring.cloud.stream.security.csrf-enabled from SecurityCommonAutoConfigurationProperties (inside core/app-starters-security-common).
Adjust existing tests with the new properties.

Resolves #24

Part of https://github.com/spring-cloud-stream-app-starters/app-starters-release/issues/161 Related to https://github.com/spring-cloud/spring-cloud-app-starters-maven-plugins/issues/36

tzolov commented 5 years ago

Depends on: https://github.com/spring-cloud-stream-app-starters/core/pull/59

dturanski commented 5 years ago

I'm getting Failures: [ERROR] HttpSourceTests$CsrfEnabledTests.testText:257 expected:<401 UNAUTHORIZED> but was:<202 ACCEPTED>

artembilan commented 5 years ago

I'm getting Failures:

Let's wait for upstream PR being merged!

Too much confusion with Maven local and potentially missed builds...

tzolov commented 5 years ago

@dturanski do you still seeing the HttpSourceTests$CsrfEnabledTests.testText:257 failures? ./mvnw clean install -U passes successfully for me.

dturanski commented 5 years ago

Works for me now