Effecient implementation of source jdbc

spring-attic / jdbc

Apache License 2.0

11 stars 18 forks source link

Effecient implementation of source jdbc #55

Open respondsid opened 4 years ago

respondsid commented 4 years ago

Current implementation uses spring integration and brings complete resultset in memory which i rhink is not very practical and doesnt make sense for a streaming platform. i wrote an optimized version of this source which is working very well for us. i would be happy to contribute it to the project if the team can review the solution.

ilayaperumalg commented 4 years ago

@respondsid Thanks for your input. Sure, please go ahead and submit your PR. We'd be happy to collaborate.

ilayaperumalg commented 4 years ago

Just so you know that we are moving into Functional applications and all the app starters are now being modified as Supplier, Function and Consumer (using the Spring Cloud Function/Stream support). If you would like to contribute, it would make sense to provide your changes based on this repository.

You can also checkout this blog series to get some more context on this: https://spring.io/blog/2020/07/13/introducing-java-functions-for-spring-cloud-stream-applications-part-0

respondsid commented 4 years ago

Sure 👍