spring-attic / mononoke

Spring Boot Application Reconcilers for Kubernetes
Apache License 2.0
0 stars 4 forks source link

Add missing dependencies to a Spring Boot Application #15

Closed ojhughes closed 4 years ago

ojhughes commented 4 years ago

Stretch goal If the spring-boot-actuator-starter is missing, we should optionally add it during build.

This pattern could be used in other places, especially if we need to provide client connectors like we do currently in SCS

ojhughes commented 4 years ago

cc @ekcasey

ekcasey commented 4 years ago

@ojhughes Are you suggesting this as a spring-boot-cnb feature?

ojhughes commented 4 years ago

@ekcasey I thought this might be just a custom builder? Just so we can add in the extra dependency

ojhughes commented 4 years ago

Alternatively, a container volume containing the desired classpath entries could be mounted with container, with the java -cp ... argument appended. This is easier to reason about I think

ojhughes commented 4 years ago

Closing following discussions on scope of spike