GH-7: Add some data processing Groovy deps

spring-attic / scriptable-transform

Apache License 2.0

0 stars 8 forks source link

Closed artembilan closed 5 years ago

artembilan commented 5 years ago

Fixes spring-cloud-stream-app-starters/scriptable-transform#7

artembilan commented 5 years ago

We can consider to include an explicit Groovy version property into our POM to uncomment those extra deps since there is no them in Spring Boot BOM.

@Haybu,

would be great if you could build this and test your script without any @Grab.

Haybu commented 5 years ago

PR Works well without @Grab. Thanks @artembilan

artembilan commented 5 years ago

Good, but I think we need to hold this PR until Spring Boot resolution in the https://github.com/spring-projects/spring-boot/issues/15468. So, we will be able to have more useful Groovy deps and still don't manage its version ourselves.

Then I'll back-port the fix too other Groovy-based projects here.

Nevertheless it is fully not related to your work with an ivy dependency and test with @Grab.

artembilan commented 5 years ago

So, Spring Boot issue for Groovy dependencies has been fixed. Therefore this PR is ready for review and merge.

Thanks

tzolov commented 5 years ago

rebased and merged at: a761a403137312cd8a4d0a88601cd6354e5ded06