search

spring-attic / spring-android

Support for Spring's RestTemplate within native Android applications
http://projects.spring.io/spring-android
Apache License 2.0
708 stars 265 forks source link

Coerce the absence of body into the empty body #28

Closed WonderCsabo closed 8 years ago

WonderCsabo commented 8 years ago

Fixes #25.

royclarkson commented 8 years ago

@WonderCsabo thanks for the PR. I'm hoping to have time over the upcoming holidays to work on this and do some testing. If you can add a few tests, that would be a big help. I'll plan on pushing out a 2.0.0.M4 or RC1 with this change, and you can use that to validate against your code.

WonderCsabo commented 8 years ago

Thanks for the feedback. Can you point me to some example tests for request factories? I already tested this against my code BTW.

royclarkson commented 8 years ago

Here are the related OkHttp tests. Thanks for the help.

https://github.com/spring-projects/spring-android/blob/master/test/spring-android-rest-template-test/src/main/java/org/springframework/http/client/OkHttpClientHttpRequestFactoryTests.java

WonderCsabo commented 8 years ago

@royclarkson I added a test. This fails before my fix and passes with may fix. The failure is exactly the same which i experienced in my real app.

royclarkson commented 8 years ago

Excellent. Thanks again for the help.

WonderCsabo commented 8 years ago

Any chance to check this out @royclarkson?

ollide commented 8 years ago

Any update on this? A 2.0.0.M4 release containing the fix would be really nice :+1:

WonderCsabo commented 8 years ago

@royclarkson thanks for merging this finally. :relaxed:

royclarkson commented 8 years ago

I know. :( too much going on. I'm pushing out a 2.0.0.M4 to get this in a release. We can figure out the OkHttp3 stuff in #29.