search

spring-attic / spring-boot-r2dbc

Experimental Spring Boot support for R2DBC
82 stars 13 forks source link

R2dbcDataAutoConfiguration should not extend from base configuration #37

Closed snicoll closed 5 years ago

snicoll commented 5 years ago

Unless I am missing something, It's a bit unusual that an auto-configuration directly extends from a base config infrastructure. What if the user has provided a AbstractR2dbcConfiguration of his own? Shouldn't we back-off in this case?

mp911de commented 5 years ago

Used the Spring Data JDBC config as inspiration. We can decouple R2dbcDataAutoConfiguration from AbstractR2dbcConfiguration.