search

spring-attic / spring-boot-r2dbc

Experimental Spring Boot support for R2DBC
82 stars 13 forks source link

@R2dbcTest imports auto-configurations that require Spring Data #42

Closed snicoll closed 4 years ago

snicoll commented 5 years ago

I am not sure naming the slice test @R2dbcTest is consistent with what we currently have given the dependency on Spring Data.

mp911de commented 5 years ago

We have actually both, @DataR2dbcTest and @R2dbcTest. @R2dbcTest does not require Spring Data R2DBC to be on the classpath. It should only configure components (Transaction manager, DatabaseClient) if they are on the classpath and back off otherwise.

snicoll commented 5 years ago

Meh, I missed that, sorry. Isn't it a bit odd that AutoConfigureR2dbc imports auto-configurations that rely on Spring Data?

snicoll commented 4 years ago

We've decided not to move the @R2dbcTest slice to Spring Boot and will reconsider once the low-level infrastructure is available outside of Spring Data.