search

spring-attic / spring-cloud-aws

All development has moved to https://github.com/awspring/spring-cloud-aws Integration for Amazon Web Services APIs with Spring
https://awspring.io/
Apache License 2.0
590 stars 375 forks source link

Support AWS SDK 2.0 #267

Open mv78 opened 6 years ago

mv78 commented 6 years ago

AWS currently in the process or releasing SDK 2.0. It would be good to start integrating it into the project as it progresses to GA.

aemruli commented 6 years ago

@mv78 just checked today. At least from the information I found they are in the preview. Hence we are waiting once AWS has released a final 2.0. I have updated the project to use the latest AWS SDK 1.x

ajainy commented 6 years ago

Can we upgrade AWS SDK v1.11.321 (latest as of May, 2018) ..? @aemruli

Or please share your last commit, i will do similar.

aemruli commented 6 years ago

@ajainy we have upgraded master to 1.11.336

michl-b commented 5 years ago

Are there any news on this? Usage with JDK11 gives some warnings on a class used in the old V1 of aws-sdk-java

WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by com.amazonaws.util.XpathUtils (file:/Users/michael/.m2/repository/com/amazonaws/aws-java-sdk-core/1.11.415/aws-java-sdk-core-1.11.415.jar) to method com.sun.org.apache.xpath.internal.XPathContext.getDTMManager() WARNING: Please consider reporting this to the maintainers of com.amazonaws.util.XpathUtils WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations WARNING: All illegal access operations will be denied in a future release

kmualem commented 5 years ago

Hi guys

Any news about AWS SDK version 2?

michaelwiles commented 5 years ago

Yes, problem with AWS SDK version 1 is it doesn't play nice with JDK 9 as it duplicates packages across individual jars.

Although an upgrade like this would touch a lot of classes it wouldn't be too hard to do as it's a simple job to upgrade to the new SDK and the new SDK is a lot easier to work with (imo it has a more fluent api).

artembilan commented 5 years ago

See another reason to do this: https://github.com/spring-cloud/spring-cloud-aws/issues/491 Also here: https://github.com/spring-projects/spring-integration-aws/issues/155

Thanks

tinexw commented 4 years ago

I started working on this here https://github.com/tinexw/spring-cloud-aws/tree/gh-267

If anyone wants to join, please let me know!

I would also like to get some insight from the maintainers what the best way to go about this is. I just started fixing compile errors and committed everything in one big commit. Not sure if that is a good idea.

Also, I'm just assuming we don't need to care about backwards compatibility. But is that correct?

spencergibb commented 4 years ago

@tinexw not sure how this would work as updating major versions of a dependency would be a breaking change

tinexw commented 4 years ago

Yeah, that's why I was asking what the preferred approach in this case is. Release a new major version?

OlgaMaciaszek commented 4 years ago

We would be very happy to take this upgrade PR, but we can't put backwards-incompatible changes within the Hoxton release train, cause it's not going to be a major. We will be shortly deciding if our next release train will be major (we will probably branch it out in a few months). If yes, then these changes could be merged there.

tinexw commented 4 years ago

Ok, thanks for the update. There is quite a lot left. I will pick it up again once you know for sure if it’s going to be a major release.

sp00m commented 4 years ago

Yet another reason to upgrade: EKS supports 2.10.11+ only... Any ETA yet?

tcheek-bw commented 4 years ago

Is this still being worked on? The 2.0 SDK would be really nice to have.

spencergibb commented 4 years ago

@tinexw started working on it and now that master would be a major release we would be happy to accept it.

tinexw commented 4 years ago

Good to know :-) I will pick it back up. Would be great to get some support especially in regards to testing later on.

tinexw commented 4 years ago

I created a PR with my changes to far: https://github.com/spring-cloud/spring-cloud-aws/pull/524 (Original comment moved to PR as well.)

sp00m commented 4 years ago

Just as an FYI, this ticket blocked us going forward, so we decided to develop our own abstraction for our Spring WebFlux projects, so that we could connect to SQS from within EKS: https://github.com/qudini/qudini-reactive/tree/master/qudini-reactive-sqs. Very SQS (and WebFlux) focused obviously, and by no means intended to replace https://github.com/spring-cloud/spring-cloud-aws, but maybe it can help resolving this issue somehow :)

maciejwalkowiak commented 4 years ago

Thanks @sp00m! We are going to move to SDK v2 in 3.0 and revisit SQS integration so we are definitely going to look at your repository for an inspiration.

internetstaff commented 3 years ago

Perhaps Spring Cloud AWS 3.0 could just be an upgrade to SDK v2 in order to knock that out sooner rather than later?

We're starting to hit issues like SSO that simply aren't supported in SDK v1.

spencergibb commented 3 years ago

The repo that would handle this is https://github.com/awspring/spring-cloud-aws