search

spring-attic / spring-cloud-aws

All development has moved to https://github.com/awspring/spring-cloud-aws Integration for Amazon Web Services APIs with Spring
https://awspring.io/
Apache License 2.0
590 stars 375 forks source link

Make it possible to disable the _profile-name suffix in AWS SSM #619

Closed TorrentKatten closed 3 years ago

TorrentKatten commented 4 years ago

This is a suggestion to make it possible to disable the _profile-name suffix expected in the SSM parameter store path. My team is using a strategy where we have one AWS account per environment so having the profile as part of the name conflicts with the naming standard we already have and makes the couldformation templates more complex. We still use the profile to configure some things we want different in test, stage and prod so it would be nice to be able to turn this off.

If you think this is a good idea I will clean up the PR, add tests and make sure everything is spiffy

pivotal-issuemaster commented 4 years ago

@TorrentKatten Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-issuemaster commented 4 years ago

@TorrentKatten Thank you for signing the Contributor License Agreement!

maciejwalkowiak commented 4 years ago

Thanks @TorrentKatten for contribution. We cannot merge it right now as it is but I am almost sure we are going to add ability to exclude fetching secrets by profile. I would appreciate if you explain in #607 how your company uses Secrets Manager as it could finally start a conversation there.

maciejwalkowiak commented 3 years ago

With the new Spring Boot 2.4 based SSM integration (that will be released in Spring Cloud AWS 2.3) this issue does not exist anymore. See more https://github.com/spring-cloud/spring-cloud-aws/issues/607