Spring cloud aws jdbc forces Tomcat data pool, could Hikari be added?

spring-attic / spring-cloud-aws

All development has moved to https://github.com/awspring/spring-cloud-aws Integration for Amazon Web Services APIs with Spring

https://awspring.io/

Apache License 2.0

590 stars 376 forks source link

Spring cloud aws jdbc forces Tomcat data pool, could Hikari be added? #661

Closed jamesgustard closed 3 years ago

jamesgustard commented 3 years ago

Any Spring boot project will be using Hikari datapool as default , so when spring cloud aws jdbc is introduced to a spring boot project the datapool is switched over to tomcat.

The TomcatJdbcDataSourceFactory seems to rely on tomcat dataource configuration being present. Could configurable Hikari support be added, if it is not already possible to use Hikari?

maciejwalkowiak commented 3 years ago

Unfortunately Spring Cloud AWS JDBC module is bound to Tomcat connection pool. Please look into #610 for improvements plan to RDS integration.