Improve tests - Githubissues

spring-attic / spring-cloud-aws

All development has moved to https://github.com/awspring/spring-cloud-aws Integration for Amazon Web Services APIs with Spring

https://awspring.io/

Apache License 2.0

590 stars 376 forks source link

Improve tests #676

Closed eddumelendez closed 3 years ago

eddumelendez commented 3 years ago

There are some tests which have not been migrated to use ApplicationContextRunner. It would be ideal to move them. Some of these test are:

[ ] AwsParamStoreBootstrapConfigurationTest
[ ] AwsSecretsManagerBootstrapConfigurationTest
[ ] ContextInstanceDataAutoConfigurationTest
[ ] ContextRegionProviderAutoConfigurationTest
[ ] ContextResourceLoaderAutoConfigurationTest
[ ] CloudWatchExportAutoConfigurationTest

Look at SimpleEmailAutoConfigurationTest for example.

Pick your test!

MatejNedic commented 3 years ago

Could I check CloudWatchExportAutoConfigurationTest for hacktoberfest?

eddumelendez commented 3 years ago

CloudWatchExportAutoConfigurationTest is all yours, @MatejNedic !

mkatircioglu commented 3 years ago

@eddumelendez I can get ContextInstanceDataAutoConfigurationTest if you are ok.

eddumelendez commented 3 years ago

@mkatircioglu Thanks for your offer! ContextInstanceDataAutoConfigurationTest is yours

eberttc commented 3 years ago

I’d like to check AwsSecretsManagerBootstrapConfigurationTest.

eddumelendez commented 3 years ago

@eberttc great! AwsSecretsManagerBootstrapConfigurationTest is yours!

shashwat1998 commented 3 years ago

@eddumelendez can I get ContextResourceLoaderAutoConfigurationTest?

eddumelendez commented 3 years ago

@shashwat1998 of course! ContextResourceLoaderAutoConfigurationTest is yours

MatejNedic commented 3 years ago

@eddumelendez since in #671 ApplicationContextRunner was introduced for CloudWatchExportAutoConfigurationTest and all tests were migrated to it, is it ok if I take AwsParamStoreBootstrapConfigurationTest

gaurav9822 commented 3 years ago

@eddumelendez can I take ContextRegionProviderAutoConfigurationTest ?

gaurav9822 commented 3 years ago

@eddumelendez Please also add "hacktoberfest" as a repo topic.

Notice from digital ocean about it- digitalocean/hacktoberfest#596

maciejwalkowiak commented 3 years ago

Thanks @gaurav9822 for the hint. We have no admin rights on the repo 🤷‍♂️. @spencergibb could you please add "hacktoberfest" to repo topics?

spencergibb commented 3 years ago

Done