search

spring-attic / spring-cloud-aws

All development has moved to https://github.com/awspring/spring-cloud-aws Integration for Amazon Web Services APIs with Spring
https://awspring.io/
Apache License 2.0
590 stars 376 forks source link

Add elasticache redis #681

Closed eddumelendez closed 3 years ago

eddumelendez commented 3 years ago

doc related [1] https://docs.aws.amazon.com/AmazonElastiCache/latest/red-ug/Clusters.ViewDetails.html [2] https://docs.aws.amazon.com/AmazonElastiCache/latest/red-ug/Endpoints.html#Endpoints.Find.Redis [3] https://docs.aws.amazon.com/AmazonElastiCache/latest/red-ug/Endpoints.html#Endpoints.Find.RedisCluster

eddumelendez commented 3 years ago

I have changed the logic to resolve if it is a cluster or not due to ClusterCache.getConfiguration is not returned. Also, I have created a ticket https://github.com/aws/aws-sdk-java/issues/2419

eddumelendez commented 3 years ago

I am thinking about having a property cluster-enabled @maciejwalkowiak WDYT?

mkatircioglu commented 3 years ago

Wouldn't it better to name module as spring-cloud-starter-aws-elasticache?

eddumelendez commented 3 years ago

Currently, we will be building on top of spring-boot-starter-data-redis in order to provide the right configuration for elasticache redis nodes and clusters. Having a spring-cloud-starter-aws-elasticache module will make sense if we want to drop memcache support which is something we have not figure it out yet and having redis as the default which sometimes can be confused. I prefer to be explicit here.

/cc @maciejwalkowiak