search

spring-attic / spring-cloud-aws

All development has moved to https://github.com/awspring/spring-cloud-aws Integration for Amazon Web Services APIs with Spring
https://awspring.io/
Apache License 2.0
589 stars 376 forks source link

fix issue #686 #712

Closed ghost closed 3 years ago

ghost commented 3 years ago

:loudspeaker: Type of change

:scroll: Description

In short, SimpleStorageResource.getURL() should return https://bucketname.s3.amazonws.com/path (e.g. https://mybucket.example.com.s3.amazonws.com/path/file.txt) instead of https://s3.region.amazonws.com/bucketname/path.

:bulb: Motivation and Context

Fix issue #686

:green_heart: How did you test it?

unit tests

:pencil: Checklist

:crystal_ball: Next steps

pivotal-issuemaster commented 3 years ago

@saritip Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-issuemaster commented 3 years ago

@saritip Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-issuemaster commented 3 years ago

@saritip Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-issuemaster commented 3 years ago

@saritip Thank you for signing the Contributor License Agreement!

maciejwalkowiak commented 3 years ago

Thank you for your PR but we are not able yet to take contributions for 3.x version, as we have to align on many things inside the team.