search

spring-attic / spring-cloud-aws

All development has moved to https://github.com/awspring/spring-cloud-aws Integration for Amazon Web Services APIs with Spring
https://awspring.io/
Apache License 2.0
589 stars 376 forks source link

SimpleStorageProtocolResolver constructor no longer visible #724

Closed paulcwarren closed 3 years ago

paulcwarren commented 3 years ago

Type: Bug

Component: S3

Describe the bug We relied on the public constructor that used to accept an AmazonS3 client but is not longer visible. Therefore we were broken when we upgraded from Hoxton.SR8 TO SR9.

Sample For additional context we have a feature that allows our users to build solutions that are multi-tenanted. Where the application context can be configured with multiple resourceloader instances. Each with its own instance of the SimpleStorageProtocolResolver with, in turn, its own configured AmazonS3 bean.

This piece of code would seem to indicate that the implementation now assumes that there will only ever be a single AmazonS3 bean in the application context.

paulcwarren commented 3 years ago

Thanks much. That's very helpful.